Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load plugins by entrypoint urls if defined #613

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Load plugins by entrypoint urls if defined #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e06e4b
Example of how to customize entrypoint urls
1000TurquoisePogs Aug 19, 2024
2540a79
Update angular2-plugin-factory.ts to handle missing entrypoint
1000TurquoisePogs Aug 27, 2024
eeec2b0
Update react-plugin-factory.ts to handle missing entrypoint
1000TurquoisePogs Aug 27, 2024
6eca934
Merge branch 'v3.x/staging' into example/v3/customizable-entrypoint-url
DivergentEuropeans Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion virtual-desktop/src/app/plugin-manager/plugin-factory/angular2/angular2-plugin-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,13 @@ class SimpleAngularComponentFactory extends ComponentFactory {
export class Angular2PluginFactory extends PluginFactory {
private readonly logger: ZLUX.ComponentLogger = BaseLogger;
private static getAngularModuleURL(pluginDefinition: MVDHosting.DesktopPluginDefinition): string {
return ZoweZLUX.uriBroker.pluginResourceUri(pluginDefinition.getBasePlugin(), 'main.js');
let pluginDefBase = pluginDefinition.getBasePlugin();
let pluginDefAny:any = (pluginDefBase as any);
let entryPoint = 'main.js';
if (pluginDefAny.getWebEntryPoint) {
entryPoint = pluginDefAny.getWebEntryPoint() || 'main.js';
}
return ZoweZLUX.uriBroker.pluginResourceUri(pluginDefBase, entryPoint);
}

private static getAngularComponentsURL(pluginDefinition: MVDHosting.DesktopPluginDefinition): string {
Expand Down
9 changes: 7 additions & 2 deletions virtual-desktop/src/app/plugin-manager/plugin-factory/react/react-plugin-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,13 @@ interface MvdNativeReactPluginComponentDefinition {
export class ReactPluginFactory extends PluginFactory {
private readonly logger: ZLUX.ComponentLogger = BaseLogger;
private static getReactModuleURL(pluginDefinition: MVDHosting.DesktopPluginDefinition): string {
// TODO: clean this up with .d.ts file
return ZoweZLUX.uriBroker.pluginResourceUri(pluginDefinition.getBasePlugin(), 'main.js');
let pluginDefBase = pluginDefinition.getBasePlugin();
let pluginDefAny:any = (pluginDefBase as any);
let entryPoint = 'main.js';
if (pluginDefAny.getWebEntryPoint) {
entryPoint = pluginDefAny.getWebEntryPoint() || 'main.js';
}
return ZoweZLUX.uriBroker.pluginResourceUri(pluginDefBase, entryPoint);
}

private static getReactComponentsURL(pluginDefinition: MVDHosting.DesktopPluginDefinition): string {
Expand Down
Loading