-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor from env vars to defaults.yaml #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge defaults.yaml. simplify zlux args to align with zlux server changes Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Default to saf when possible Signed-off-by: 1000TurquoisePogs <[email protected]>
new argParser.CLIArgument('allowInvalidTLSProxy', null, | ||
argParser.constants.ARG_TYPE_VALUE), | ||
new argParser.CLIArgument('mlUser', 'mu', argParser.constants.ARG_TYPE_VALUE), | ||
new argParser.CLIArgument('mlPass', 'mp', argParser.constants.ARG_TYPE_VALUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alert automation that we'll be breaking them here.
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
…eature/v2/defaults-yaml Signed-off-by: 1000TurquoisePogs <[email protected]>
Add zss agent section to app-server section Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
…erver into feature/v2/defaults-yaml
struga0258
approved these changes
Jun 26, 2023
Signed-off-by: 1000TurquoisePogs <[email protected]>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the server from depending heavily on a confusing list of environment variable decision making for configuration, to instead having a configuration based almost entirely on YAML files, and includes its own defaults.yaml file to refer to and build upon.
This will support both dev and prod. In prod, the defaults file will be used in combination with the user's yaml file, allowing that to be brief but yet make visible how you can customize the server further.
In dev, the defaults.yaml will be copied to ~/.zowe/zowe.yaml if it doesnt exist, which will give you a starting point for customization. From then on, the server would by default load both that file and the defaults.yaml file.
The defaults.yaml file is found within defaults/serverConfig/defaults.yaml
It uses configmgr-like templating in the format of
${{ }}
with some tweaks:os.
andprocess.
calls because it's getting executed in nodejs, not configmgr.function a() {thing}; a()
a bit, to accomplish the same thing.This PR addresses Issue: zowe/zlux#914
This PR depends upon the following PRs: zowe/zlux-server-framework#473
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
This PR should [ass existing automation for dev and prod. use it as you would normal zowe. additionally, you can find tests of yaml files within https://github.com/zowe/zlux-server-framework/pull/473