Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Changelog file check #275

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Conversation

sagar-1310
Copy link
Contributor

@sagar-1310 sagar-1310 commented Aug 1, 2023

Proposed changes

This PR adds the check to verify if the 'Changelog.md' file is updated or not

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

@struga0258
Copy link
Contributor

Are you sure this works?? Can you make a similar pr with a CHANGELOG edited?? Also please print out a better error.. Currently you are just printing CHANGELOG. One more thing please remove the directory checkout as it might interfere with the build later or place it in some folder that wont interfere with build .

@sagar-1310
Copy link
Contributor Author

Hi James, Yes I created it on a separate repository, and while adding here some parts of the error message were missed. I am going to update the same. Also, I agree with your point so I will remove the directory checkout from here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 2, 2023
@1000TurquoisePogs 1000TurquoisePogs merged commit 46b795d into v2.x/staging Aug 7, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants