Remove container-specific discovery url logic #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.14.0 we revamped discovery url logic to work better for HA/FT
This cleanup removed some hardcoded evaluation of ZWE_DISCOVERY_SERVICES_LIST within the server, so that the server now relies on the zowe.yaml (specifically, defaults.yaml) content only.
In v2.12.0 we discovered weird behavior on containers that worked best when we had the line
if (process.env.ZWE_RUN_IN_CONTAINER=="true" && process.env.ZWE_GATEWAY_HOST) {Only, this logic seems to depend upon that old hardcoding of ZWE_DISCOVERY_SERVICES_LIST.
Now that that is removed, container registration is broken.
This PR attempts to fix container registration by removing that conditional so that the registration just does use ZWE_DISCOVERY_SERVICES_LIST as it did before.