Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Try to detect
ssh
andtelnet
port by looking into/etc/ssh/sshd_config
and/etc/services
. If such check fails, set the default port22
and23
(same as now).This PR addresses Issue:
app-server
start-up. This approach is independent on thezowe.yaml
changes: you can set the Zowe not to useapp-server
and later change it.Type of change
PR Checklist
Please delete options that are not relevant.
Testing
Small unit test
Test for checking if the logic works as expected:
Running without variables
In the log:
Running with preset
ZWED_SSH_PORT
In the log:
Further comments
I keep the setting in
defaults.yaml
. It should work without that, because those variables are exported. But in the future, there might be a way how to do it in JavaScript, keep it as reference.