Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log into zowe.runtimeDirectory #317

Open
wants to merge 6 commits into
base: v3.x/staging
Choose a base branch
from

Conversation

Martin-Zeithaml
Copy link

@Martin-Zeithaml Martin-Zeithaml commented Aug 20, 2024

Proposed changes

This PR addresses the problem found in: zowe/zowe-install-packaging#3495

Type of change

Please delete options that are not relevant.

  • Refactor the code
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

zowe.logDirectory not used in config:

No log directory. Logging disabled.     
ZWED_NODE_LOG_FILE=/dev/null            
...
No log directory. Logging disabled.    
ZWES_LOG_FILE=/dev/null                

zowe.logDirectory set to /zowe/logs/

ZWED_NODE_LOG_FILE=/zowe/logs/appServer-2024-08-27-07-39.log  
ZWES_LOG_FILE=/zowe/logs/zssServer-2024-08-27-07-39.log   

Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
@Martin-Zeithaml Martin-Zeithaml changed the title Do not log into zowe.runtimeDirectory Do not log into zowe.runtimeDirectory [WIP] Aug 21, 2024
Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 23, 2024
@Martin-Zeithaml Martin-Zeithaml changed the title Do not log into zowe.runtimeDirectory [WIP] Do not log into zowe.runtimeDirectory Aug 27, 2024
Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

@skurnevich skurnevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merge Ready
Development

Successfully merging this pull request may close these issues.

2 participants