added test linter yml

Signed-off-by: Himani1519 <[email protected]>

.eslintrc.js

@@ -0,0 +1,48 @@
+/*
+  This program and the accompanying materials are
+  made available under the terms of the Eclipse Public License v2.0 which accompanies
+  this distribution, and is available at https://www.eclipse.org/legal/epl-v20.html
+
+  SPDX-License-Identifier: EPL-2.0
+
+  Copyright Contributors to the Zowe Project.
+*/
+
+module.exports = {
+  env: {
+    browser: true,
+    es6: true,
+    node: true
+  },
+  globals: {
+    describe: 'readonly',
+    it: 'readonly',
+    before: 'readonly',
+    after: 'readonly',
+    beforeEach: 'readonly',
+    afterEach: 'readonly',
+  },
+  ignorePatterns: ['.github/**/*.yml', '**/.build', '**/build', '**/dist', '**/node_modules', '**/release', '**/lib','**/test/yaml-loader'],
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:import/recommended',
+    'plugin:import/typescript'
+  ],
+  parser: '@typescript-eslint/parser',
+  plugins: ['header'],
+  rules: {
+    'header/header': [
+      2,         // Error level
+      'block',   // Location
+     [
+        '\n  This program and the accompanying materials are' +
+       '\n  made available under the terms of the Eclipse Public License v2.0 which accompanies' +
+       '\n  this distribution, and is available at https://www.eclipse.org/legal/epl-v20.html' +
+       '\n\n  SPDX-License-Identifier: EPL-2.0\n\n  Copyright Contributors to the Zowe Project.\n'
+     ],
+      2,
+    ],
+  },
+}

.github/workflows/test-lint.yml

@@ -0,0 +1,26 @@
+name: Lint TypeScript
+
+on:
+  push:
+    branches:
+      - v2.x/staging
+  pull_request:
+    types: [opened, reopened, synchronize]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: '18'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Lint TypeScript
+        run: npm run lint

package.json

@@ -4,7 +4,6 @@
   "description": "A Server for zLUX Plugins, Dataservices, and Proxying to other Servers.",
   "license": "EPL-2.0",
   "homepage": "zowe.org",
-  "type": "module",
   "repository": {
     "type": "git",
     "url": "https://github.com/zowe/zlux-server-framework.git"

test/plugin-loader/depgraph.js

@@ -1,12 +1,12 @@
 /*
- * This program and the accompanying materials are made available under the terms of the
- * Eclipse Public License v2.0 which accompanies this distribution, and is available at
- * https://www.eclipse.org/legal/epl-v20.html
- *
- * SPDX-License-Identifier: EPL-2.0
- *
- * Copyright Contributors to the Zowe Project.
- */
+  This program and the accompanying materials are
+  made available under the terms of the Eclipse Public License v2.0 which accompanies
+  this distribution, and is available at https://www.eclipse.org/legal/epl-v20.html
+
+  SPDX-License-Identifier: EPL-2.0
+
+  Copyright Contributors to the Zowe Project.
+*/
 
 import { strict as assert } from 'assert';
 import Depgraph from '../../lib/depgraph';

test/plugin-loader/plugin-loader.js

@@ -1,13 +1,13 @@
-
 /*
   This program and the accompanying materials are
   made available under the terms of the Eclipse Public License v2.0 which accompanies
   this distribution, and is available at https://www.eclipse.org/legal/epl-v20.html
-  
+
   SPDX-License-Identifier: EPL-2.0
-  
+
   Copyright Contributors to the Zowe Project.
 */
+
 import assert from 'assert';
 import path from 'path';
 import PluginLoader from '../../lib/plugin-loader';

test/webserver/multibind.js

@@ -8,9 +8,9 @@
   
   Copyright Contributors to the Zowe Project.
 */
-const assert = require('assert')
-const zluxUtil = require('../../lib/util.js')
-const pd = "..\..\..\\zlux-app-server\\deploy\\product"
+import assert from 'assert';
+import zluxUtil from '../../lib/util.js';
+//const pd = "../../../zlux-app-server/deploy/product";
 
 global.COM_RS_COMMON_LOGGER.setLogLevelForComponentPattern("_zsf.network", 5);
 

tsconfig.json

@@ -8,8 +8,9 @@
   "exclude": ["lib/*.js"],
   "compilerOptions": {
     "sourceMap": true,
+    "module": "ES6",
     "moduleResolution": "node",
-    "target": "es5",
+    "target": "ES6",
     "types": [
       "node",
       "express"

utils/argumentParser.js

@@ -74,7 +74,7 @@ function CLIArgument(longName, shortName, type) {
   return {
     getMatch: getMatch
   };
-};
+}
 exports.CLIArgument = CLIArgument;
 
 /*
@@ -96,7 +96,7 @@ function resolveJson(argumentsObj, matchObj) {
     returnVal = {};
   }
   let currentLevel = returnVal;
-  let currentIndex = -1;
+//  let currentIndex = -1;
   const partLen = matchParts.length-1;
   try {
     for (let i = 0; i < partLen; i++) {
@@ -134,6 +134,7 @@ function resolveJson(argumentsObj, matchObj) {
 
 function ArgumentParser(validArgs, argArray) {
   var validArguments = validArgs;
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   var args = argArray;
 
   var parse = function(args) {
@@ -284,8 +285,8 @@ function stringToValue(stringVal, csvAsArray) {
 }
 exports.stringToValue = stringToValue;
 
-
 function testEnv() {
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
   let input0 = {ABC:"1",
                ABC_123: "2",
                ABC__123: "3",
@@ -392,7 +393,7 @@ function testEnv() {
                _______aBC_______123_______: "122",
                 __0__abc__1__def: "123"
                };
-
+/* eslint-disable-next-line no-unused-vars */
   let input = {
 
                node_mediationLayer_server_gatewayPort:"$GATEWAY_PORT",

utils/install-app.js

@@ -8,13 +8,13 @@
  Copyright Contributors to the Zowe Project.
 */
 
-const fs = require('graceful-fs');
-const Promise = require('bluebird');
-const path = require('path');
-const packagingUtils = require('./packaging-utils');
-const serverUtils = require('../lib/util');
-const jsonUtils = require('../lib/jsonUtils');
-const rmrf = require('rimraf');
+import * as fs from 'graceful-fs';
+//const Promise = require('bluebird');
+import * as path from 'path';
+import { packagingUtils } from './packaging-utils';
+import * as serverUtils from '../lib/util';
+import * as jsonUtils from '../lib/jsonUtils';
+//import * as rmrf from 'rimraf';
 
 //assuming that this is file isnt being called from another that is already using the logger... else expect strange logs
 //TO DO - Sean - bootstrap logger
@@ -28,13 +28,13 @@ try { // Attempt to get a log message for a language a user may have specified
 }
 logger._messages = messages;
 
-const argParser = require('./argumentParser');
+import * as argParser from './argumentParser';
 //const usage = 'Usage: --inputApp | -i INPUTAPP --pluginsDir | -p PLUGINSDIR '
 //      + '--zluxConfig | -c ZLUXCONFIGPATH [--verbose | -v]';
 
 //TODO if plugins get extracted read-only, then how would we go about doing upgrades? read-write for now!
 const FILE_WRITE_MODE = 0o660;
-const DIR_WRITE_MODE = 0o770;
+//const DIR_WRITE_MODE = 0o770;
 
 const OPTION_ARGS = [
   new argParser.CLIArgument('inputApp', 'i', argParser.constants.ARG_TYPE_VALUE),
@@ -96,9 +96,9 @@ function isFile(path) {
   return false;
 }
 
-function cleanup() {
-  logger.warn(`ZWED0147W`); //logger.warn(`Cleanup not yet implemented`);
-}
+//function cleanup() {
+//  logger.warn(`ZWED0147W`); //logger.warn(`Cleanup not yet implemented`);
+//}
 
 function addToServer(appDir, installDir) {
   try {
@@ -177,6 +177,7 @@ function copyRecognizers(appDir, appId, appVers) {
           configRecognizers = JSON.parse(fs.readFileSync(filepathConfig)).recognizers;
           const configRecognizersKeys = Object.keys(configRecognizers);
           for (const configKey of configRecognizersKeys) { // Traverse config recognizers
+            // eslint-disable-next-line no-undef
             for (const key of recognizerKeys) { // Traverse plugin recognizers
               if (configRecognizers[configKey].key && recognizers[key].key && configRecognizers[configKey].key == recognizers[key].key) { // TODO: Need to implement real keys for Recognizers
                 configRecognizers[configKey] = recognizers[key]; // Choose the recognizers originating from plugin
@@ -244,7 +245,8 @@ function copyActions(appDir, appId, appVers) {
 
 if(calledViaCLI){
   if (!isFile(userInput.inputApp)) {
-    const pluginDefinition = packagingUtils.validatePluginInDirectory(userInput.inputApp);
+//    const pluginDefinition =
+    packagingUtils.validatePluginInDirectory(userInput.inputApp);
     addToServer(userInput.inputApp);  
   } else {
     packagingUtils.endWithMessage(`App given was not a directory. Not yet implemented: Package extraction`);

utils/mergeUtils.js

@@ -11,7 +11,7 @@
 function deepAssign(target, source) {
   var retVal = {}
   if (Array.isArray(target)) {
-	  retVal = target;
+    retVal = target;
   } else if (typeof target === 'object' && target) {
     Object.keys(target).forEach(function (key) {
       retVal[key] = target[key];

utils/packaging-utils.js

@@ -2,21 +2,21 @@
  This program and the accompanying materials are
  made available under the terms of the Eclipse Public License v2.0 which accompanies
  this distribution, and is available at https://www.eclipse.org/legal/epl-v20.html
- 
+
  SPDX-License-Identifier: EPL-2.0
- 
+
  Copyright Contributors to the Zowe Project.
 */
 
-const path = require('path');
-const Promise = require('bluebird');
-const fs = require('graceful-fs');
+import path from 'path';
+import Promise from 'bluebird';
+import fs from 'graceful-fs';
 //assuming that this is file isnt being called from another that is already using the logger... else expect strange logs
-const logging = require('../../zlux-shared/src/logging/logger.js');
+import type { logging } from '../../zlux-shared/src/logging/logger.js';
 const coreLogger = new logging.Logger();
 //simple program, no need for logger names to be displayed
 coreLogger.addDestination(coreLogger.makeDefaultDestination(true,false,false));
-
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 let logger;
 
 exports.coreLogger = coreLogger;
@@ -29,7 +29,7 @@ function mkdirp(dir, options) {
     if (dir == '.') {
       resolve();
     } else {
-      fs.stat(dir, (err, stats)=> {
+      fs.stat(dir, (err)=> {
         if (!err) {
           //exists
           resolve();
@@ -43,6 +43,7 @@ function mkdirp(dir, options) {
                 resolve();
               }
             });
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
           }).catch((err)=> {
             reject();
           });
@@ -75,7 +76,7 @@ function validatePluginInDirectory(inputDir) {
     endWithMessage(`Couldn't read pluginDefinition.json within ${inputDir}, e=${e}`);
   }
   return pluginDefinition;
-};
+}
 exports.validatePluginInDirectory = validatePluginInDirectory;
 
 function endWithMessage(message) {