Add gateway to app server component checking #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
1000TurquoisePogs
requested changes
Apr 5, 2022
lib/plugin-loader.js
Outdated
| if(config.node.mediationLayer && | ||
| config.node.mediationLayer.enabled && | ||
| config.node.mediationLayer.server){ | ||
| requestOptions.host = config.node.mediationLayer.server.hostname |
There was a problem hiding this comment.
gatewayHostname, see https://github.com/zowe/zlux-server-framework/blob/v1.x/staging/lib/index.js#L245
lib/plugin-loader.js
Outdated
| } | ||
| return new Promise((resolve, reject) => { | ||
| httpApi.get(requestOptions, (res) => { | ||
| const { statusCode } = res; // TODO: Check status code for bad status |
There was a problem hiding this comment.
considering the gateway often starts slower than app-server, i think you need some sort of loop w/ timeout here because it's highly likely to fail on the first request.
added 4 commits
April 6, 2022 09:28
…framework into bugfix/explorers
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
| @@ -959,12 +971,66 @@ PluginLoader.prototype = { | |||
| bootstrapLogger.severe(e.message); | |||
| resolve(); // We don't want to reject here. Error gets caught down stream | |||
| }); | |||
| }) | |||
| }).then(() => { /* Obtains and stores the endpoints exposed by the agent */ | |||
There was a problem hiding this comment.
Think this comment was meant to be on line 945, line 975 can say the same thing except for API ML
added 2 commits
April 6, 2022 21:21
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
added 2 commits
April 12, 2022 11:14
Signed-off-by: Timothy Gerstel <[email protected]>
…framework into bugfix/explorers
1000TurquoisePogs
requested changes
Apr 12, 2022
lib/plugin-loader.js
Outdated
|
|
||
| const gatewayCheck = () => { | ||
| if (Date.now() > end) { | ||
| log.warn(`ZWED0045`, this.apimlHost, this.apimlPort); |
There was a problem hiding this comment.
2022-04-12 20:34:27.699 <:> me WARN (_zsf.bootstrap,process.js:29) ZWED0036W - Uncaught exception found. Error:
ReferenceError: log is not defined
ZWED0037W - Ending server process due to uncaught exception.
ZWED0050I - Server shutting down, received signal=SIGQUIT
added 4 commits
April 13, 2022 09:47
Signed-off-by: Timothy Gerstel <[email protected]>
…ficient timeout length to connect to the mediation layer Signed-off-by: Timothy Gerstel <[email protected]>
…into bugfix/explorers
Signed-off-by: Timothy Gerstel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments