Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows and deps for technical currency #169

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Dec 24, 2024

What It Does

Also updates ibm_db dependency to support Node.js 22 and native installation on M1 Macs

How to Test

Note: I had to uninstall and reinstall XCode tools before I could install the plug-in on my Mac - see https://www.itsfullofstars.de/2024/10/solution-for-npm-install-fails-with-node-gyp-error-memory-file-not-found/

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (a1de287) to head (d3906ba).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files          24       24           
  Lines         337      337           
  Branches       44       43    -1     
=======================================
  Hits          252      252           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review December 24, 2024 15:59
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm unable to run any DB2 commands directly from my Mac, I was able to build it and install it on my personal Apple Silicon laptop 😋

Thanks Timothy, LGTM!

Signed-off-by: Timothy Johnson <[email protected]>
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit d509f34 into master Jan 2, 2025
23 checks passed
@zFernand0 zFernand0 deleted the chore/update-workflows-and-deps branch January 2, 2025 15:18
@zFernand0 zFernand0 added the release-minor Indicates a minor feature has been added label Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Indicates a minor feature has been added released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants