Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Update workflows and deps for technical currency #170

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

t1m0thyj
Copy link
Member

What It Does

Also updates ibm_db dependency to support Node.js 22 on Windows (w/o enhancement for M1 Macs)

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.22%. Comparing base (a3f0ac5) to head (04bd311).
Report is 8 commits behind head on zowe-v2-lts.

Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v2-lts     #170   +/-   ##
============================================
  Coverage        75.22%   75.22%           
============================================
  Files               25       25           
  Lines              331      331           
  Branches            41       42    +1     
============================================
  Hits               249      249           
  Misses              82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested building and installing the plugin with Node 22 and LGTM, thanks for the updates!

Signed-off-by: Timothy Johnson <[email protected]>
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit 93aac6e into zowe-v2-lts Jan 2, 2025
19 checks passed
@zFernand0 zFernand0 deleted the chore/v2-update-workflows-and-deps branch January 2, 2025 15:19
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Jan 2, 2025
@zFernand0 zFernand0 mentioned this pull request Jan 2, 2025
4 tasks
@zFernand0
Copy link
Member

zFernand0 commented Jan 2, 2025

This PR didn't release because the v2 branch was nor in the release config file

Once we merge the PR below, we should be fine:

Copy link

github-actions bot commented Jan 6, 2025

Release succeeded for the zowe-v2-lts branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants