Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to make contribution steps easier to follow #42

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 30, 2023

Update the readme to add installation steps and summary of each step. Thanks @robertblum-psi for suggesting improvements to the readme.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a list of commands?
😋

LGTM!

@zFernand0 zFernand0 linked an issue Dec 13, 2023 that may be closed by this pull request
@t1m0thyj t1m0thyj self-assigned this Dec 26, 2023
@t1m0thyj t1m0thyj changed the title Update README.md to mention cloning as first step Update README.md to make contribution steps easier to follow Jan 3, 2024
@t1m0thyj t1m0thyj requested review from zFernand0 and awharn January 3, 2024 15:26
@t1m0thyj t1m0thyj marked this pull request as ready for review January 3, 2024 15:26
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

README.md Outdated Show resolved Hide resolved
Signed-off-by: Timothy Johnson <[email protected]>
Copy link

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

A few things that you should address:

  • Decide whether to use "plug-in" or "plugin." I see both styles in this content, and there should only be one.
  • Decide whether to capitalize Web Help or not. I see both styles in this content, and there should only be one.
  • Decide whether to italicize your steps. There's no ital in Installing, but there is ital in the other sections. There should only be one formatting style consistently used through this ReadMe.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj requested a review from anaxceron January 3, 2024 18:21
Copy link

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@t1m0thyj t1m0thyj merged commit bc16c3d into master Jan 3, 2024
7 checks passed
@t1m0thyj t1m0thyj deleted the t1m0thyj-patch-1 branch January 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions in help are incorrect
5 participants