-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore-not-found flag logic to zosfilesBase.handler and update command definitions and en.ts for delete operations #2254
Conversation
… for all but mds Signed-off-by: ATorrise <[email protected]>
Signed-off-by: ATorrise <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2254 +/- ##
========================================
Coverage 91.16% 91.16%
========================================
Files 636 636
Lines 18034 18034
Branches 3770 3879 +109
========================================
Hits 16440 16440
Misses 1593 1593
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ATorrise <[email protected]>
Perhaps it's too late to adjust this, but I wanted to make an observation... I also came across this suggested "standards" reference which links to description:
Alternatively, a more descriptive command option for this command group could be used ~ |
Signed-off-by: ATorrise <[email protected]>
packages/cli/__tests__/zosfiles/__unit__/delete/zfs/zfs.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__unit__/delete/zfs/zfs.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: zFernand0 <[email protected]>
packages/cli/__tests__/zosfiles/__unit__/delete/zfs/zfs.handler.unit.test.ts
Fixed
Show fixed
Hide fixed
… for these unit tests Signed-off-by: ATorrise <[email protected]>
packages/cli/__tests__/zosfiles/__unit__/delete/zfs/zfs.handler.unit.test.ts
Show resolved
Hide resolved
Signed-off-by: ATorrise <[email protected]>
packages/cli/__tests__/zosfiles/__system__/delete/ds/cli.files.delete.ds.system.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__system__/delete/vsam/cli.files.delete.vsam.system.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosfiles/__system__/delete/zfs/cli.files.delete.zfs.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: ATorrise <[email protected]>
Signed-off-by: ATorrise <[email protected]>
I think this is a good point that If it's not too late to change, I support the idea of |
Signed-off-by: ATorrise <[email protected]>
Signed-off-by: Amber <[email protected]>
Signed-off-by: Amber <[email protected]>
Signed-off-by: Amber <[email protected]>
Signed-off-by: Amber <[email protected]>
Signed-off-by: Amber <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
I believe these requested changes were addressed in d20417c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @ATorrise! Left a few comments
packages/cli/__tests__/zosfiles/__system__/delete/uss/cli.files.delete.file.system.test.ts
Show resolved
Hide resolved
packages/cli/__tests__/zosfiles/__system__/delete/vsam/cli.files.delete.vsam.system.test.ts
Show resolved
Hide resolved
packages/cli/__tests__/zosfiles/__system__/delete/zfs/cli.files.delete.zfs.system.test.ts
Show resolved
Hide resolved
packages/cli/__tests__/zosfiles/__unit__/create/zfs/zfs.handler.unit.test.ts
Show resolved
Hide resolved
packages/cli/__tests__/zosfiles/__unit__/mount/fs/fs.handler.unit.test.ts
Outdated
Show resolved
Hide resolved
…tion of file across all delete system tests Signed-off-by: Amber <[email protected]>
Added the
|
Signed-off-by: Amber <[email protected]>
Signed-off-by: Amber <[email protected]>
@zFernand0 @t1m0thyj not sure what to do about this? |
I wouldn't worry too much about the duplication. If we do plan to reduce duplication, I guess I'd prefer to do it on a major release boundary, as part of our cleanup efforts 😋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise for the new feature and thorough system tests!
Quality Gate failedFailed conditions |
What it Does
This PR implements the
--ignore-not-found
flag for delete operations across DS, USS, zFS, and VSAM by:ZosFilesBaseHandler
to handle--ignore-not-found
and suppress errors when a file or data set does not exist (HTTP 404 or IDC3012I).--ignore-not-found
flag.en.ts
to reflect the new flag in descriptions and examples.How to Test
Verify that the
--ignore-not-found
flag works for all delete operations (DS, USS, zFS, VSAM) by attempting to delete things that don't exist. Delete non-existent files/data sets with and without--ignore-not-found
.zowe zos-files delete data-set "ibmuser.cntl" -fi
zowe zos-files delete uss-file "/a/ibmuser/testcases" -fi
zowe zos-files delete zos-file-system "HLQ.MYNEW.ZFS" -fi
zowe zos-files delete data-set-vsam "ibmuser.AAA.**.FFF" -fi
zowe zos-files delete data-set "ibmuser.cntl" -f
zowe zos-files delete uss-file "/a/ibmuser/testcases" -f
zowe zos-files delete zos-file-system "HLQ.MYNEW.ZFS" -f
zowe zos-files delete data-set-vsam "ibmuser.AAA.**.FFF" -f
Review Checklist
I certify that I have:
Additional Comments
This update is for all delete operations except MDS (which does not currently support this flag)