-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Config API bugs that affect extenders converting V1 profiles #2313
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2313 +/- ##
==========================================
+ Coverage 91.18% 91.27% +0.09%
==========================================
Files 636 636
Lines 18057 18066 +9
Branches 3781 3784 +3
==========================================
+ Hits 16465 16490 +25
+ Misses 1591 1575 -16
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for the fixes Timothy! I have a small request about updating typedoc for clarity, other than that the changes LGTM
fix: Ignore events within the app that triggered them
Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Fixes #2284, #2311, #2312
ProfileInfo.profileManagerWillLoad
so that it works without requiringreadFromConfigDisk
to be called first.ProfileInfo.onlyV1ProfilesExist
so that it works outside of Zowe CLI whenImperativeConfig.instance.config
is undefined. This required changing it from a static method to an instance method.ConvertV1Profiles
API detecting V1 profiles inprocess.env.ZOWE_CLI_HOME
, but not creating V2 config there.How to Test
false
if both V1 profiles and V2 config are present, (b) Should ignore presence of meta files:ZOWE_CLI_HOME
dir:export ZOWE_CLI_HOME=/tmp/.zowe zowe config convert-profiles
Review Checklist
I certify that I have:
Additional Comments