Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing GetJobs.getJob #2320

Merged
merged 15 commits into from
Oct 28, 2024
Merged

Enhancing GetJobs.getJob #2320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f497283
code implementation plus tests
pujal0909 Oct 23, 2024
1925533
updated the changelog
pujal0909 Oct 23, 2024
e2f2b25
linting issues fixed
pujal0909 Oct 23, 2024
08e0dc8
Merge remote-tracking branch 'origin/master' into enhance-ijob
pujal0909 Oct 23, 2024
6c08a00
updated unit tests sample jobs
pujal0909 Oct 24, 2024
cec51f4
updated code
pujal0909 Oct 24, 2024
fc488da
fixed linting errors
pujal0909 Oct 24, 2024
c8cf9ee
updated code with PR comments
pujal0909 Oct 24, 2024
53f296a
fixed getJobs() error
pujal0909 Oct 25, 2024
6464b9d
Merge branch 'master' into enhance-ijob
awharn Oct 28, 2024
a8f0cf4
Delete packages/imperative/__tests__/src/packages/imperative/plugins/…
pujal0909 Oct 28, 2024
fc954cf
Merge branch 'master' into enhance-ijob
awharn Oct 28, 2024
f408fc3
updated iJob interface
pujal0909 Oct 28, 2024
11cd8ae
updated snapshots
pujal0909 Oct 28, 2024
5d7f071
Merge branch 'master' into enhance-ijob
zFernand0 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/cli/__tests__/zosjobs/__resources__/GetJobsData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ export class GetJobsData {
public static readonly SAMPLE_COMPLETE_JOB: IJob = {
"jobid": "TSUxxx",
"jobname": "IBMUSER$",
"exec-started": '2024-01-02T15:57:58.350Z',
"exec-ended": '2024-01-02T15:58:00.600Z',
"exec-member": 'SYS1',
"exec-system": 'SYS1',
"exec-submitted": '2024-01-02T15:58:00.600Z',
"subsystem": "JES2",
"owner": "IBMUSER",
"status": "OUTPUT",
Expand All @@ -49,6 +54,11 @@ export class GetJobsData {
public static readonly SAMPLE_COMPLETE_JOB_AGAIN: IJob = {
"jobid": "JOBxxx",
"jobname": "CAUSER$",
"exec-started": '2024-01-02T15:57:58.350Z',
"exec-ended": '2024-01-02T15:58:00.600Z',
"exec-member": 'SYS1',
"exec-system": 'SYS1',
"exec-submitted": '2024-01-02T15:58:00.600Z',
"subsystem": "JES2",
"owner": "CAUSER",
"status": "OUTPUT",
Expand Down Expand Up @@ -79,6 +89,11 @@ export class GetJobsData {
public static readonly SAMPLE_ACTIVE_JOB: IJob = {
"retcode": null,
"jobname": "KELDA16$",
"exec-started": '2024-01-02T15:57:58.350Z',
"exec-ended": '2024-01-02T15:58:00.600Z',
"exec-member": 'SYS1',
"exec-system": 'SYS1',
"exec-submitted": '2024-01-02T15:58:00.600Z',
"status": "INPUT",
"job-correlator": "J0003781USILDAMDD3CE8146.......:",
"class": "A",
Expand Down
10 changes: 10 additions & 0 deletions ...ges/cli/__tests__/zosjobs/__unit__/cancel/job/__snapshots__/Job.handler.unit.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ exports[`cancel job handler tests should be able to cancel a job by job id 2`] =
exports[`cancel job handler tests should be able to cancel a job by job id 3`] = `
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -29,6 +34,11 @@ exports[`cancel job handler tests should be able to cancel a job by job id versi
exports[`cancel job handler tests should be able to cancel a job by job id version 2.0 3`] = `
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand Down
10 changes: 10 additions & 0 deletions ...ges/cli/__tests__/zosjobs/__unit__/delete/job/__snapshots__/Job.handler.unit.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ exports[`delete job handler tests should be able to delete a job by job id 2`] =
exports[`delete job handler tests should be able to delete a job by job id 3`] = `
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -29,6 +34,11 @@ exports[`delete job handler tests should be able to delete a job by job id versi
exports[`delete job handler tests should be able to delete a job by job id version 2.0 3`] = `
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand Down
80 changes: 80 additions & 0 deletions ..._tests__/zosjobs/__unit__/delete/old-jobs/__snapshots__/OldJobs.handler.unit.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ Object {
"output": Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -28,6 +33,11 @@ Object {
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand All @@ -51,6 +61,11 @@ exports[`delete old-jobs handler tests should delete all jobs using defaults in
Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -66,6 +81,11 @@ Array [
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand Down Expand Up @@ -95,6 +115,11 @@ Object {
"output": Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -110,6 +135,11 @@ Object {
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand All @@ -133,6 +163,11 @@ exports[`delete old-jobs handler tests should delete all jobs using defaults seq
Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -148,6 +183,11 @@ Array [
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand Down Expand Up @@ -177,6 +217,11 @@ Object {
"output": Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -192,6 +237,11 @@ Object {
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand All @@ -215,6 +265,11 @@ exports[`delete old-jobs handler tests should delete jobs with a specific prefix
Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -230,6 +285,11 @@ Array [
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand Down Expand Up @@ -259,6 +319,11 @@ Object {
"output": Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -274,6 +339,11 @@ Object {
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand All @@ -297,6 +367,11 @@ exports[`delete old-jobs handler tests should delete jobs with modifyVersion 2.0
Array [
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "TSUxxx",
Expand All @@ -312,6 +387,11 @@ Array [
},
Object {
"class": "A",
"exec-ended": "2024-01-02T15:58:00.600Z",
"exec-member": "SYS1",
"exec-started": "2024-01-02T15:57:58.350Z",
"exec-submitted": "2024-01-02T15:58:00.600Z",
"exec-system": "SYS1",
"files-url": "www.nowhere.com/restjobs/jobs/files",
"job-correlator": "123545asdfadf",
"jobid": "JOBxxx",
Expand Down
Loading