-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help web 2 #2363
Help web 2 #2363
Conversation
Signed-off-by: Amber <[email protected]>
Signed-off-by: Amber <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
- Coverage 91.27% 91.27% -0.01%
==========================================
Files 636 636
Lines 18071 18071
Branches 3895 3787 -108
==========================================
- Hits 16495 16494 -1
- Misses 1575 1576 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - LGTM, thanks @ATorrise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Question: Do we consider this an enhancement or a bug fix. That is, should all of the help modifications be backported to V2?
Personally, I would be comfortable with leaving it only in V3.
What It Does
Modified 8.8.2 bugfix to correct web help alias. #2361
How to Test
Ensure help-web can be called with --hw and --help-web despite faulty config.
Review Checklist
I certify that I have: