Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help web 2 #2363

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Help web 2 #2363

merged 2 commits into from
Nov 18, 2024

Conversation

ATorrise
Copy link
Contributor

What It Does
Modified 8.8.2 bugfix to correct web help alias. #2361

How to Test
Ensure help-web can be called with --hw and --help-web despite faulty config.

  • this pr exists because I accidentally added the alias with just 1 dash instead of 2 to imperative.ts

Review Checklist
I certify that I have:

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (cb9e71b) to head (2f5d61c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         636      636              
  Lines       18071    18071              
  Branches     3895     3787     -108     
==========================================
- Hits        16495    16494       -1     
- Misses       1575     1576       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - LGTM, thanks @ATorrise!

@ATorrise ATorrise added the release-current Indicates that there is no new functionality being delivered label Nov 15, 2024
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Question: Do we consider this an enhancement or a bug fix. That is, should all of the help modifications be backported to V2?

Personally, I would be comfortable with leaving it only in V3.

@zFernand0 zFernand0 merged commit 33b8d94 into master Nov 18, 2024
20 checks passed
@zFernand0 zFernand0 deleted the help-web-2 branch November 18, 2024 15:09
@zFernand0 zFernand0 added release-patch Indicates a patch to existing code has been applied and removed release-current Indicates that there is no new functionality being delivered labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants