add tagging for upload.bufferToUssFile

[jace-roell]

What It Does
Add file tagging to Upload.bufferToUssFile

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.27%. Comparing base (e684b78) to head (f2aac76).
Report is 13 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/zosfiles/src/methods/upload/Upload.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         638      638              
  Lines       18141    18146       +5     
  Branches     3914     3915       +1     
==========================================
+ Hits        16559    16563       +4     
- Misses       1581     1582       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[traeok]

Changes make sense to me, thanks Jace for the fix!

[anaxceron]

Requesting an edit to the changelog : )

[zFernand0]

Took me a few minutes to figure out testing steps since Upload.bufferToUssFile is not exposed on any CLI command 😓

Still testing since I ran into a small hiccup 😋

Full testing script

/* Save this file as `test.mjs` and run `node test.mjs` */

import { ProfileInfo } from "@zowe/imperative";
import { Upload } from "@zowe/zos-files-for-zowe-sdk";
import * as fs from "fs";
(async () => {
    // Load connection info from default z/OSMF profile
    const profInfo = new ProfileInfo("zowe");
    await profInfo.readProfilesFromDisk();
    const zosmfProfAttrs = profInfo.getDefaultProfile("zosmf");
    const zosmfMergedArgs = profInfo.mergeArgsForProfile(zosmfProfAttrs, { getSecureVals: true });
    const session = ProfileInfo.createSession(zosmfMergedArgs.knownArgs);

    const localFile = "package.json";
    const localFileContents = fs.readFileSync(localFile).toString();
    const remoteLocation = "/u/users/fernando/test-file1.txt";
    const options = { binary: true };
    // const response = await Upload.fileToUssFile(session, localFile, remoteLocation, options);
    const response = await Upload.bufferToUssFile(session, remoteLocation, Buffer.from(localFileContents), options);
    console.log(response);
})().catch((err) => {
    console.error(err);
    process.exit(1);
});

[zFernand0]

LGTM! 😋

When I tested it, I had a version of master cached in the build.
My mistake.
Files get tagged as expected 🙏

[zFernand0]

Besides the changelog updates requested by Ana, I think that my comments are mostly nice-to-have(s).
Don't feel obligated to implement them 😋
Just figured I mention it to have other your thoughts on them 😋

[zFernand0]

The sonar cloud issues are related to very old commented out code.
Feel free to remove those commented out lines of code if you would like, but I don't believe that it should hold the PR from being merged 😋

[anaxceron]

Requesting a minor edit to the changelog

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud