Update workflows and deps for technical currency #2397
+41
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2397 +/- ##
========================================
Coverage 91.28% 91.28%
========================================
Files 638 638
Lines 18208 18208
Branches 3822 3930 +108
========================================
Hits 16621 16621
Misses 1586 1586
Partials 1 1 ☔ View full report in Codecov by Sentry. |
t1m0thyj
force-pushed
the
chore/update-workflows-and-deps
branch
from
62d50c5 to
ea6da7e
Compare
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
force-pushed
the
chore/update-workflows-and-deps
branch
from
ea6da7e to
27ef793
Compare
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
force-pushed
the
chore/update-workflows-and-deps
branch
from
a45d2cc to
8d1dc81
Compare
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
|
📅 Suggested merge-by date: 1/9/2025 |
t1m0thyj
requested review from
ATorrise,
gejohnston,
jace-roell and
pujal0909
t1m0thyj
commented
Dec 26, 2024
| @@ -37,4 +37,4 @@ jobs: | |||
|
|
|||
| - name: Check Secrets SDK Vulnerabilities | |||
| working-directory: packages/secrets/src/keyring | |||
| run: cargo audit --deny warnings --ignore RUSTSEC-2024-0370 | |||
| run: cargo audit --deny warnings --ignore RUSTSEC-2024-0370 --ignore RUSTSEC-2024-0429 | |||
There was a problem hiding this comment.
RUSTSEC-2024-0429 should be safe to ignore since there is no CVE associated with it and we don't use the affected function.
If it was easy to update the glib crate I would do so, but we're kind of locked down to a specific version for maximum compatibility with libsecret across multiple distros.
traeok
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Also removes some obsolete/redundant steps from Zowe CLI workflow.
While diagnosing daemon-related test errors I updated the way we return non-zero exit codes in the daemon client to conform to Rust best practices.
How to Test
Review Checklist
I certify that I have:
Additional Comments