-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list): Add maxLength
and start
options to List SDK functions
#2409
base: master
Are you sure you want to change the base?
Conversation
…llMembers Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
…n fns Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2409 +/- ##
========================================
Coverage 91.33% 91.33%
========================================
Files 639 639
Lines 18248 18251 +3
Branches 3834 3945 +111
========================================
+ Hits 16666 16670 +4
+ Misses 1580 1579 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
d654e2b
to
14c3826
Compare
Signed-off-by: Trae Yelovich <[email protected]>
maxLength
and start
options to List SDK functions
📅 Suggested merge-by date: 1/29/2025 |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
I left one comment regarding uri encoding things 😋
Could we chat about it briefly? 😋
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
thanks for addressing the comment so quickly 🙏
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reverting the format changes. 😋
I'm not opposed if you'd like to run it agains the entire repo (on a separate PR) 🙏
Also, this worked fine with special characters 🙏
FERNANDO.A10123.ENCO#ED.DATA
Thanks!
Quality Gate passedIssues Measures |
What It Does
maxLength
option to List SDK functions (allMembers, dataSetsMatchingPattern, membersMatchingPattern
) to specify the maximum number of items to return.start
option to List SDK functions (allMembers, dataSetsMatchingPattern, membersMatchingPattern
) to specify the first data set/member name to return in the response.start
option inList.dataSet
. Now, the test validates thatstart
works as expected.How to Test
See the scripts in this gist.
npm install && npm run build
from the root of the repo.packages/zosfiles
maxLength
script, replace the "USER.*" pattern with a pattern that will match results for your default z/OSMF profile.start
script, replace the pattern mentioned in step 3 and adjust the value for thestart
option to match a data set listed by the pattern.maxLength
is respected (e.g.maxLength: 1
returns only one data set matching the pattern)start
is respected (e.g. "USER.*" with "USER.STARTDS" as thestart
option results in the list starting withUSER.STARTDS
)Review Checklist
I certify that I have:
Additional Comments