Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure value censorship refactor #2424

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 3, 2025

What It Does

Refactors LoggerUtils into a new Censor class to globally use the same list of censored options, and intelligently add options to censor on the fly. Also removes duplication (and deprecates functions) to the old utilities. Points old utilities to use the new utility when possible.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 96.21622% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.39%. Comparing base (9340db9) to head (dcad7cb).

Files with missing lines Patch % Lines
packages/imperative/src/censor/src/Censor.ts 94.57% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
+ Coverage   91.36%   91.39%   +0.03%     
==========================================
  Files         639      641       +2     
  Lines       18283    18364      +81     
  Branches     3923     3874      -49     
==========================================
+ Hits        16704    16784      +80     
- Misses       1577     1578       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
78.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Signed-off-by: Andrew W. Harn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant