-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specified the port in the Getting Started -> Basic Usage page in the documentation #238
Conversation
Signed-off-by: Maira Usman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Myrausman Thanks for your contribution!
In addition to adding the port, these examples need a few other changes to bring them up to date. They're using old code that is no longer the recommended way to load connection details from CLI profiles.
Please make the following changes:
Example 1
from zowe.zos_console_for_zowe_sdk import Console
connection = {
"host_url": "'<host address>'",
"port" : 443 , # Include the port if different from the default (443)
"user": "<user>",
"password": "<password>",
}
my_console = Console(connection)
- Rename
connection
toprofile
- Change
host_url
tohost
and remove the extra single quotes ('
)
Example 2
from zowe.zos_console_for_zowe_sdk import Console
connection = {
"plugin_profile": "<profile name>>"
}
my_console = Console(connection)
The connection
object should be replaced with a profile
loaded using the ProfileManager class from the core SDK (see example here).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 34 34
Lines 2084 2084
=======================================
Hits 1741 1741
Misses 343 343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maira Usman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the changes 🙂 Left one more minor comment
Signed-off-by: Maira Usman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Myrausman!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
LGTM! 😋
What It Does
issue resolved #162
Review Checklist
I certify that I have: