Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload file to USS and integration tests #248

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jan 9, 2024

What It Does

Fixes several issues with upload/download methods and adds integration tests to verify that they work

How to Test

Create a team config file in the repo and run integration tests with pytest tests/integration

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (2d79e9c) 83.75% compared to head (7a2f34b) 83.83%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py 6.45% 29 Missing ⚠️
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   83.75%   83.83%   +0.07%     
==========================================
  Files          34       34              
  Lines        2118     2116       -2     
==========================================
  Hits         1774     1774              
+ Misses        344      342       -2     
Flag Coverage Δ
unittests 83.83% <43.61%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
All integration and unit tests passed locally 😋

@zFernand0
Copy link
Member

🥳 let's merge it 😋

@t1m0thyj t1m0thyj merged commit 8aa91ad into main Jan 10, 2024
23 of 24 checks passed
@t1m0thyj t1m0thyj deleted the fix/upload-file-to-uss branch January 10, 2024 19:46
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

  • pypi: zowe-1.0.0.dev14
  • pypi: zowe_core_for_zowe_sdk-1.0.0.dev14
  • pypi: zowe_zos_console_for_zowe_sdk-1.0.0.dev14
  • pypi: zowe_zos_files_for_zowe_sdk-1.0.0.dev14
  • pypi: zowe_zos_jobs_for_zowe_sdk-1.0.0.dev14
  • pypi: zowe_zos_tso_for_zowe_sdk-1.0.0.dev14
  • pypi: zowe_zosmf_for_zowe_sdk-1.0.0.dev14

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zos-files] download_dsn fails to write contents to disk Investigate integration test failures
3 participants