Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename modules os to cm_os and std to cm_std #375

Merged
merged 3 commits into from
May 3, 2023

Conversation

pj892031
Copy link
Contributor

@pj892031 pj892031 commented Apr 26, 2023

Proposed changes

This PR renames two modules (os > cm_os, std > cm_std). It is for the implementation of zowe/zowe-install-packaging#3352. Modules os and std were clashing with the default implementation of the node. It was not possible to establish a unit tests in the ZWE command.

Cannot be achieved: The PR also replaces the representation of string values in the config manager to be readable for the developer (because makefile uses C89 and it doesn't support IBM pragma convert).

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

pj892031 added a commit to zowe/zowe-install-packaging that referenced this pull request Apr 26, 2023
Signed-off-by: Pavel Jareš <[email protected]>
@pj892031
Copy link
Contributor Author

pj892031 commented May 2, 2023

tested in zowe/zowe-install-packaging#3388

@pj892031 pj892031 marked this pull request as ready for review May 2, 2023 07:29
Copy link

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JoeNemo JoeNemo merged commit c865cc5 into v2.x/staging May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants