[TEST] quickjs with profiling enabled #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MarkAckert <[email protected]>
|
@MarkAckert Do you need my assistance to merge to quickjs-portable? |
Signed-off-by: MarkAckert <[email protected]>
|
Hey Joe, I might need help, but after the holidays. The merge conflicts weren't too complex but I've still managed to hit some compilation errors after the merge, and I assume there could be other runtime issues as well. If I get stuck I'll reach out. |
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
|
I was able to get the profiling code in and working, but it's not generating enough data to be useful for line coverage. I'm going to close this PR but leave the branch around, I might revisit this in the future and take a shot at adding line coverage to quickjs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream quickjs pull request 371 enables profiling which includes some coverage information in its output. Goal is to see if we can use this to enable line coverage for zwe tests.
I used a new fork to merge code changes from quickjs-portable into the upstream PR.