-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate NOTICE file for packages #3143
Conversation
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 113 113
Lines 11669 11669
Branches 2498 2494 -4
=======================================
Hits 10829 10829
Misses 838 838
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
📅 Suggested merge-by date: 10/8/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for generating these Billie - I noticed there are some merge conflicts but everything LGTM!
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JillieBeanSim for setting up the script to generate NOTICE files.
We discussed on standup yesterday about the possibility of using a common Zowe pipeline to generate the notices. Worked with @MarkAckert to enhance the same dependency scanner workflow that is used for CLI and we've added a new licenses artifact for VSCode. Would this work for attribution purposes?
once we have our files PR to watch zowe/zowe-dependency-scan-pipeline#149 |
Now that zowe/zowe-dependency-scan-pipeline#149 was merged, are we good to close this PR? 🙏 |
verified that our zip file is included in the 3.0.0 of artifactory |
Proposed changes
Generate NOTICE file for packages, with NOTICE file header used from ZOWE CLI package from zowe.org/downloads distribution
can install new dependency into a package and run
pnpm run update-notices
to see the new package picked up and added to NOTICE file for the ZE package updated. This command will be added to the release preparation and ran when new dependencies introduced into the packages having file changes verified then pushed into release PR along with lerna updates.I do notice it doesn't add ZE API or our eslint-plugin with the SNAPSHOT in version, we will have to update that manually when command run for publishing.
adding Zowe package values manually where appropriate when missing after looking through files, all zowe packages will be updated for GA instances in release PR
Release Notes
Milestone: v3 GA
Changelog: Generate NOTICE file for package.
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments