Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/jack/ansible tests #1193

Merged
merged 47 commits into from
Mar 19, 2020
Merged

Users/jack/ansible tests #1193

merged 47 commits into from
Mar 19, 2020

Conversation

jackjia-ibm
Copy link
Member

@jackjia-ibm jackjia-ibm commented Mar 17, 2020

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

This is pre-req work required by:

Changes proposed in this PR

  • Using Ansible to drive Zowe installation,
  • New test cases of installation, which allows extension in the future,
  • Sanity tests are imported from zowe-install-test.
  • zowe-install-test can be archived soon after this is merged.

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
@jackjia-ibm
Copy link
Member Author

@stevenhorsman
Copy link
Member

@jackjia-ibm - did you mean to add us as reviewers rather than assign the PR to us? Is it ready now?

@jackjia-ibm
Copy link
Member Author

jackjia-ibm commented Mar 17, 2020

@stevenhorsman yes it's ready for reviewing the first stage work, which is converting all functions we have on zowe-install-test.

The ongoing and future works will be:

  • port the PTF install test to playbooks,
  • add extended test scenarios (multiple instances of installation, multiple node.js version, acf2/ts)
  • add plugin install and test.

(I just noticed I "assigned" PR instead asked for "review", has been fixed.)

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't claim to understand all the ansible stuff, but I've tried to go through and have a couple of minor suggestions to clean up/clarify. I'll try and get my hands dirty with it soon to understand it better soon.

playbooks/README.md Outdated Show resolved Hide resolved
playbooks/roles/configure/defaults/main.yml Outdated Show resolved Hide resolved
playbooks/roles/configure/defaults/main.yml Outdated Show resolved Hide resolved
playbooks/roles/zos/files/opercmd Outdated Show resolved Hide resolved
playbooks/roles/zowe/defaults/main.yml Outdated Show resolved Hide resolved
tests/installation/Jenkinsfile Outdated Show resolved Hide resolved
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
@jackjia-ibm
Copy link
Member Author

Thanks a lot @stevenhorsman for the suggestions. I've resolved all of them and ran another 2 tests:

which are both successful.

@jackjia-ibm jackjia-ibm merged commit 7615376 into staging Mar 19, 2020
@jackjia-ibm jackjia-ibm deleted the users/jack/ansible-tests branch March 19, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants