-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/jack/ansible tests #1193
Users/jack/ansible tests #1193
Conversation
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Test run are successful with:
|
@jackjia-ibm - did you mean to add us as reviewers rather than assign the PR to us? Is it ready now? |
@stevenhorsman yes it's ready for reviewing the first stage work, which is converting all functions we have on zowe-install-test. The ongoing and future works will be:
(I just noticed I "assigned" PR instead asked for "review", has been fixed.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't claim to understand all the ansible stuff, but I've tried to go through and have a couple of minor suggestions to clean up/clarify. I'll try and get my hands dirty with it soon to understand it better soon.
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Signed-off-by: Jack (T.) Jia <[email protected]>
Thanks a lot @stevenhorsman for the suggestions. I've resolved all of them and ran another 2 tests:
which are both successful. |
Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.
PR type
What type of changes does your PR introduce to Zowe? Put an
x
in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.Relevant issues
This is pre-req work required by:
Changes proposed in this PR
Does this PR introduce a breaking change?
Does this PR do something the person installing Zowe should know about?
multi-line description
Is there a related doc issue or Pull Request?
Doc issue/PR number:
Other information