Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node 18, but not 18.12.1 #3485

Merged

Conversation

1000TurquoisePogs
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs commented Jul 3, 2023

This PR formally adds node v18 support to the servers.
There was nothing preventing 18 from running, but after testing we know that while node 18.14 works, node 18.12.1 on zos does not. Therefore, this PR really just adds a check to forbid 18.12.1, while letting all other versions run.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

  • Feature

Relevant issues

Related to zowe/zlux#973
Documentation: zowe/docs-site#2976

Does this PR introduce a breaking change?

  • No

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

PAX build 3390 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5444242001

Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Test workflow 2900 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3485/zowe-2.10.0-pr-3485-3390-20230703121007.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5444300919

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

PAX build 3391 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5444323708

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Test workflow 2901 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3485/zowe-2.10.0-pr-3485-3391-20230703121955.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5444391105

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

PAX build 3432 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5508352266

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Test workflow 2943 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3485/zowe-2.10.0-pr-3485-3432-20230710130442.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5508436512

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

PAX build 3445 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5511613562

@zowe-robot zowe-robot temporarily deployed to marist-zzow02 July 10, 2023 18:38 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Test workflow 2954 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3485/zowe-2.10.0-pr-3485-3445-20230710183616.pax
Running on machine: zzow02
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5511714890

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

PAX build 3448 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5514423918

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Test workflow 2958 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3485/zowe-2.10.0-pr-3485-3448-20230711003815.pax
Running on machine: zzow03
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5514465896

@zowe-robot zowe-robot temporarily deployed to marist-zzow04 July 11, 2023 12:40 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Test workflow 2960 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.10.0-PR-3485/zowe-2.10.0-pr-3485-3448-20230711003815.pax
Running on machine: zzow04
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/5520046412

@1000TurquoisePogs 1000TurquoisePogs merged commit 4d1f2db into v2.x/staging Jul 11, 2023
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/allow-18-but-not-first-release branch July 11, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants