-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate appfw plugins schema during component install #3866
Validate appfw plugins schema during component install #3866
Conversation
Signed-off-by: 1000TurquoisePogs <[email protected]>
…at exit can be handled after cleanup Signed-off-by: 1000TurquoisePogs <[email protected]>
build 5443 SUCCEEDED. |
Test workflow 4761 is started. |
Signed-off-by: 1000TurquoisePogs <[email protected]>
build 5486 SUCCEEDED. |
Test workflow 4826 is started. |
build 5490 SUCCEEDED. |
Test workflow 4832 is started. |
Resolves #3863 by simply checking for appfwPlugin entries in a component manifest and then running a loop of
getPluginDefinition()
during the install extract step (called during both install and upgrade) but not caring about the output - it either passes or quits in error if schema is invalid.I put this in a spot of the code where the component directory is still a temp dir - not yet resolved so that if a failure occurs then the folder can be removed.