Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language refactor ZWECONF.xml #3913

Closed
wants to merge 3 commits into from

Conversation

janan07
Copy link
Contributor

@janan07 janan07 commented Jul 15, 2024

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes

Changes proposed in this PR

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

janan07 added 2 commits July 15, 2024 14:42
Signed-off-by: Andrew Jandacek <[email protected]>
Signed-off-by: Andrew Jandacek <[email protected]>
Copy link

github-actions bot commented Jul 15, 2024

build 5652 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9939702459

Copy link

github-actions bot commented Jul 15, 2024

Test workflow 5030 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3913/zowe-2.17.0-pr-3913-5652-20240715125609.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9939805594

Copy link

github-actions bot commented Jul 16, 2024

build 5658 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9955873405

Copy link

github-actions bot commented Jul 16, 2024

Test workflow 5037 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3913/zowe-2.17.0-pr-3913-5658-20240716112747.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9955965135

@@ -268,7 +268,11 @@ some use cases, like containerization, this port could be different.</descriptio
</variable>
<variable name="zowe_certificate_keystore_file" scope="instance" visibility="public">
<label>Zowe certificate keystore file</label>
<abstract>Zowe certificate keystore file. In case of keyring the format is "safkeyring://OWNER/KEYRING".</abstract>
<<<<<<< Updated upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@MarkAckert
Copy link
Member

The other workflow PR was merged into v2.x/staging, and there were language corrections in there. Is this PR still required or can we close it? @janan07 @pavelzlatnik

@js665999
Copy link
Contributor

@MarkAckert

The other workflow PR was merged into v2.x/staging, and there were language corrections in there. Is this PR still required or can we close it?

Can be closed, no capacity by @janan07. We will revisit workflows for more language updates later.

@MarkAckert MarkAckert closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants