Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix defaults for keyring config #3917

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

skurnevich
Copy link
Contributor

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes

Changes proposed in this PR

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

Signed-off-by: Sergei Kurnevich <[email protected]>
Copy link

github-actions bot commented Jul 17, 2024

build 5668 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9974537776

Copy link

github-actions bot commented Jul 17, 2024

Test workflow 5048 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.17.0-PR-3917/zowe-2.17.0-pr-3917-5668-20240717125733.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9974664740

@skurnevich skurnevich closed this Jul 17, 2024
@skurnevich skurnevich reopened this Jul 17, 2024
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an acceptable compromise to me.

What this would do in effect ensure dname and validity sections whenever keyrings are used.
This is more broad than necessary, but will prevent other bugs for now until a more specific solution is made.
The consequence is you'll end up with dname and validity environment variables set in scenarios where they're actually unused.
I do not expect any components/extensions would be reading "zowe.setup.certificate.keyring.dname" for any reason, so I think this is a fine solution for now.

@1000TurquoisePogs 1000TurquoisePogs merged commit 3ab1680 into v2.x/rc Jul 17, 2024
11 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the skurnevich/defaults-keyring-fix branch July 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants