Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zOSMF validate cleanup [WIP] #3948

Closed
wants to merge 6 commits into from
Closed

Conversation

Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml commented Aug 21, 2024

Fixes #3932

  • Function bin/libs/zosmf.ts: validateZosmfAsAuthProvider and the corresponding shell version is evaluating the default setting as an error:
ERROR: z/OSMF is not configured. Using z/OSMF as authentication provider is not supported. 
  • JS version of ZWEL0141E was returning user id "$(get_user_id)" instead of real user id.
  • Function names in messages changed to real names

Tests

When ZOSMF_HOST and ZOSMF_PORT are defined:

With valid values:

2024-08-22 07:43:12 <ZWELS:50725631> martin INFO (zwe-internal-start-prepare,globalValidate) process global validations ... 
Successfully checked z/OS MF is available on 'https://skynet:800/zosmf/info'    

With invalid values:

bin/utils/curl.js: Request failed (ENOTFOUND): getaddrinfo ENOTFOUND skinet

couple of "zwe-internal-start-prepare" messages

ERROR: Warning: Could not validate if z/OS MF is available on 'https://skinet:801/zosmf/info'. No response code from z/OSMF server.
ERROR: 2024-08-22 07:45:03 <ZWELS:33949307> martin ERROR (zwe-internal-start-prepare,globalValidate) Zosmf validation failed

Note: The change in curl.js makes the log little bit better to read, it is more obvious, that the "Request failed" and ERROR are related and coming from the same check.

Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Aug 21, 2024

build 5778 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10487136939

Copy link

github-actions bot commented Aug 21, 2024

Test workflow 5179 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3948/zowe-3.0.0-pr-3948-5778-20240821092851.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10487265430

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Aug 22, 2024

build 5781 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10504063616

Copy link

github-actions bot commented Aug 22, 2024

Test workflow 5183 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3948/zowe-3.0.0-pr-3948-5781-20240822075855.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10504130526

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Aug 22, 2024

build 5783 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10504492849

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Aug 22, 2024

build 5784 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10504521698

Copy link

github-actions bot commented Aug 22, 2024

Test workflow 5184 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3948/zowe-3.0.0-pr-3948-5783-20240822083054.pax
Running on machine: zzow06
Result: CANCELLED
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10504608872

Copy link

github-actions bot commented Aug 22, 2024

Test workflow 5185 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3948/zowe-3.0.0-pr-3948-5784-20240822083159.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10504625810

@Martin-Zeithaml Martin-Zeithaml deleted the v3.x/validateZosmf branch August 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants