Print error message on invalid extension install package (v2) #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
|
build 6697 SUCCEEDED. |
zowe-robot
temporarily deployed
to
marist-zzow09
GitHub Actions
Inactive
|
Test workflow 5899 is started. |
Martin-Zeithaml
approved these changes
Jan 9, 2025
1000TurquoisePogs
deleted the
bugfix/v2/error-on-invalid-extension-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, if you try to install an extension with a filename ending in something other than .tar, .pax, or .zip you'll get an error like:
TypeError: cannot read property 'rc' of undefined
at execute (/zowe/bin/commands/components/install/extract/index:83)
This is because there is no "else" case on the file extension types.
So, this PR adds an "else" that just prints the error: