Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix file copy #376

Open
wants to merge 11 commits into
base: v1.x/staging
Choose a base branch
from
Open

Unix file copy #376

wants to merge 11 commits into from

Conversation

adrazilo
Copy link

@adrazilo adrazilo commented Nov 30, 2021

Proposed changes

This PR fixes the unixFileCopy command on the mock server so that it properly updates the global directory and returns a message response.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

To test this feature, please consider the following test conditions:

  1. A folder/file can be copied to an from any path.
  2. A folder/file does not override an existing folder/file
  3. A folder/file that does not exist is not copied

Further comments

This is my first PR! It is also a great introductory task to working with the mock server.

Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, /copy endpoint looks good to me! 🍨 Tested forceOverwrite, newName attribs too, yield proper responses

TODOs make sense

mock/server.py Outdated Show resolved Hide resolved
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Signed-off-by: Alexandra Drazilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants