Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zwes1606w message for troubleshooting #663

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

1000TurquoisePogs
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs commented Nov 2, 2023

When you have a JWK error, you currently get output like this:

error initing session: 17
failed to obtain JWK, status = 9
ZWES1606W Failed to get JWK - failed to send HTTP request, retry in 10 seconds

9 = "failed to send http request", so this is redundant.
17 is mysterious.
and overall, this message spams when nothing is wrong but zowe isnt fully loaded yet.

this PR decreases the ZWES1606W message to only fire every 10 intervals (100 seconds by default), and skips the first 10 to potentially avoid 1606w entirely during normal timing events.
this PR eliminates the top 2 lines, consolidating them into ZWES1606W, which now will print:

ZWES1606W Failed to get JWK. rc=failed to send HTTP request (9), rsn=TLS error (17). Retry in 10 seconds

Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@JoeNemo JoeNemo merged commit 5ca217d into v2.x/staging Nov 21, 2023
5 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/jwk-message-simplify branch November 28, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants