Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for dual ESM/CJS #301

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Better support for dual ESM/CJS #301

merged 1 commit into from
Aug 17, 2023

Conversation

zpao
Copy link
Owner

@zpao zpao commented Aug 17, 2023

  • Use exports field
  • Ship local package.json files with type specified.

- Use exports field
- Ship local package.json files with `type` specified.
@zpao zpao added this to the 4.0.0 milestone Aug 17, 2023
@zpao zpao linked an issue Aug 17, 2023 that may be closed by this pull request
@zpao zpao merged commit 15f4b93 into trunk Aug 17, 2023
16 checks passed
@zpao zpao deleted the better-modules-support branch August 18, 2023 20:32
@zpao zpao modified the milestones: 4.0.0, 3.2.0 Aug 3, 2024
@gergelybodor
Copy link

@zpao when do you plan on releasing 3.2.0? This would be a welcome fix.

@zpao zpao modified the milestones: 3.2.0, 4.0.0 Aug 31, 2024
zpao added a commit that referenced this pull request Sep 1, 2024
- Use exports field
- Ship local package.json files with `type` specified.

(cherry picked from commit 15f4b93)
@zpao
Copy link
Owner Author

zpao commented Sep 1, 2024

@gergelybodor I shipped this and the followup in v4 earlier this week and v3.2 just now. I'd recommend v4 but there was this and another compatibility thing that were enough to pull into a 3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants