Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use inline scripts to render the widget #26

Closed
wants to merge 3 commits into from
Closed

Don't use inline scripts to render the widget #26

wants to merge 3 commits into from

Commits on Jan 31, 2018

  1. Try to fall back to django.jQuery 

    So that we will function in django admin, when JQUERY_URL is set to None
(because the rest of the site provides a jQuery).
    @stefanor
    stefanor committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    3b0e644 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Configure MarkItUp editors from a script after document ready 

    Rather than using inline scripts, just apply some attributes to the
widget, so we can locate it later in the DOM.

This means jQuery doesn't have to be loaded before the MarkItUpWidget or
markitup_editor tag is rendered on a page, all scripts can be loaded in
the document foot.

Fixes: zsiciarz#25
    @stefanor
    stefanor committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    ca9fa98 View commit details
    Browse the repository at this point in the history

  2. Refactor tests for our changes to markup 

    Use multiple TestCases for the widget + template tag variations rather
than auto_preview permutations.
    @stefanor
    stefanor committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    f9667e6 View commit details
    Browse the repository at this point in the history