Remove query param from URL when its value is default #181
Conversation
tsnobip
force-pushed
the
remove-query-param-when-default
branch
from
a1dba21 to
dfcfdb2
Compare
| @@ -85,6 +85,8 @@ module QueryParams = { | |||
| | Boolean => `switch ${variableName} { | true => "true" | false => "false" }` | |||
| | Int => `Int.toString(${variableName})` | |||
| | Float => `Float.toString(${variableName})` | |||
| | CustomModule({moduleName, required: true}) => | |||
| `${variableName} == ${moduleName}.defaultValue ? None : ${variableName}->${moduleName}.serialize->Some` | |||
There was a problem hiding this comment.
I don't have a better solution, but I don't think == works well enough to be used in this context. IIRC there are a few issues around newer representations we've implemented. I could be wrong though.
The only other way I can think of to do it is to serialize before comparing. That'll give a stable comparable value. It could be hurtful to performance if serializing is expensive, but that's probably rarely the case, and it's not done often. At that point one could consider caching the serialization of the default value, or something along those lines.
What do you think about serializing before comparing?
There was a problem hiding this comment.
It'd make sense, anyway we'd serialize the value without this feature, so it's the same complexity!
tsnobip
force-pushed
the
remove-query-param-when-default
branch
from
dfcfdb2 to
becb82c
Compare
tsnobip
force-pushed
the
remove-query-param-when-default
branch
from
becb82c to
842e52a
Compare
...ples/client-rendering/src/routes/__generated__/Route__Root__Todos__ByStatusDecoded_route.res
Outdated
Show resolved
Hide resolved
tsnobip
force-pushed
the
remove-query-param-when-default
branch
from
ad71ae3 to
503d151
Compare
to rebase on main once #180 is merged