Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to clarify bats-assert loading #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhart-r7
Copy link

In this documentation there was some inconsistency with regards to which bats supporting libraries were being referred to. The result was that if you followed this verbatim for the common github submodule case, many of the asserts wouldn't work and it might not be immediately obvious why. This PR updates the documentation to be more consistent in this regard -- now both bats-support and bats-assert are both always referenced.

@jasonkarns
Copy link
Contributor

I think we should probably even consider replacing git submodules with git subtrees* as the recommended installation option (as subtrees require a lot less management bookkeeping than submodules.)

in addition to this PR, not instead of

@jhart-r7
Copy link
Author

jhart-r7 commented May 8, 2019

Yes, in reading up on subtrees I agree that might be a good alternative in the future, but for now (to your point) I think this PR would be helpful to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants