Support npm #2
Merged
Support npm #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is sorta dependant on ztombol/bats-assert#3 since both bats-assert and bats-core need tagged releases. The released version will need set in the package.json as |
|
v0.1.0 was tagged so the package.json has been updated to reflect that version number. This minimal package.json is now ready to merge. Adding all the extra metadata |
|
@jasonkarns Could you do the same for |
|
@ztombol yep! |
|
@jasonkarns Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal package.json.
nameandversionare required by npm to install.privateis not required, but is to prevent this module from accidentally being published to npm until/if desired. (I think it's advisable to leverage github for now.)Of course, there is a lot of other metadata that would be useful in the package:
description,homepage,repository,bugs,licenseHowever, since bpkg also uses package.json (currently, anyway), I added only the bare minimum properties at the moment.
I'm waiting to open a similar PR to bats-assert until any issues are discussed here, (since the bats-assert package.json will be virtually the same). The only difference is that the bats-assert package.json will include bats-core as a dependency (direct or peer, TBD)