Remove unnecessary escapes #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the ESLint rule
no-useless-escapeto highlight unnecessary escapes in the Regex. You can also see this Stack Overflow answer for more details on characters that need to be escaped and those that do not need to be escaped when inside character classes.I also noticed that the
should still remove escaped markdown syntaxtest is not working correctly, because the string\# Heading in _italic_is interpreted as# Heading in _italic_, and if you add double backslashes in the beginning (\\# Heading in _italic_) the test fails. You can see more details about using backslashes in strings here.If you want me to add ESLint as a development dependency to the project, with the
no-useless-escaperule as the only active rule, let me know.