Fixes #386 : Compose box doesn't auto-open when narrowing #390
Conversation
|
Automated message from Dropbox CLA bot @saketkumar95, it looks like you've already signed the Dropbox CLA. Thanks! |
There was a problem hiding this comment.
I think the issue was to hide the chatbox when messageHeaders are clicked :)
|
Yes, the issue was with message headers ("recipient bars" is what we call them usually). |
|
@timabbott @Sam1301 Yeah, i got that wrong. But i think this should also be there. Whenever someone clicks on the stream, the compose box automatically opens up. Instead it should not. Same as on web. |
|
Agreed, maybe just add a second commit fixing the other issue? |
|
@timabbott Yeah, sure. :) |
| @@ -1204,6 +1204,8 @@ public boolean onChildClick(ExpandableListView parent, View v, int groupPosition | |||
| String subjectName = ((Cursor) streamsDrawer.getExpandableListAdapter().getChild(groupPosition, childPosition)).getString(0); | |||
| onNarrow(new NarrowFilterStream(streamName, subjectName)); | |||
| onNarrowFillSendBoxStream(streamName, subjectName, false); | |||
| hideView(chatBox); | |||
There was a problem hiding this comment.
would be better to use displayChatbox(boolean) and displayFAB(boolean)
|
@saketkumar95 this looks nice, can you please address the comment here? |
|
@saketkumar95, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts. |
Summary of changes
This PR fixes https://github.com/zulip/zulip-android/issues/386
Now compose box doesn't auto-open when narrowing.
Screenshots or a brief video showing the change in action:
Code is formatted.
Run the lint tests with
./gradlew lintDebugand make sure BUILD is SUCCESSFULCommit messages are well-written.