Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fro preview multiple #2799

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

IdrisDY
Copy link

@IdrisDY IdrisDY commented Dec 3, 2022

Fixes Issue/Linear Ticket - https://linear.app/team-repute/issue/FRO-103/preview-multiple-files

( This could be an existing issue or a linear ticket )

My PR Fixes FRO-103-Preview mulitple files

Changes proposed

What were you told to do?

I was told to fix the previewing of multiple files after adding one by one to stop resetting.
Fix the passing of attached file handler function props to work in MessageBoard.

What did you do?

I changed the state of the attached file into an array .

Check List (Check all the applicable boxes)

🚨Please review the style guide for contributing and guidelines for contributing to this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/ Videos

Copy link
Collaborator

@ickynavigator ickynavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You failed to add a video showing your new implementation actually works

@@ -81,13 +81,12 @@ const ToolbarBottom = props => {
//Handles sending of attachedfile
const handleAttachMedia = e => {
{
e.preventDefault();
// e.preventDefault();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

//Then this is to clear the file from the state
props.sentAttachedFile(null);
clearAttached();
// props.sentAttachedFile(null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants