Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): improve colors contrast in dark mode #4092

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robertsLando
Copy link
Member

Fixes #4091

@robertsLando
Copy link
Member Author

@zackbcom got time to checkout this?

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12866237943

Details

  • 0 of 44 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 21.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/utils.js 0 3 0.0%
src/plugins/vuetify.js 0 11 0.0%
src/components/nodes-table/nodes-table.js 0 30 0.0%
Totals Coverage Status
Change from base Build 12813824348: -0.02%
Covered Lines: 3952
Relevant Lines: 19978

💛 - Coveralls

@zackbcom
Copy link
Contributor

zackbcom commented Jan 17, 2025

I don't think the purple was adjusted for everything.

I mostly have issues with the dark purple with little area for the color
Examples:
image
image

Maybe we can scrap the color changes and adjust just those two items.
Make the Z-Wave Long Range Button have a solid color?
image

After looking at the green button with the white text, that might need to be adjusted a bit darker.
Maybe we can set it to dark text?
New changes:
image
new change with #1e1e1e
image
old change:
image

Before

image

After

image

It was fixes in settings though.

Before

image

After

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Contrast for Purple on UI
3 participants