Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store nodes preferences in nodes.json using homeHex #4104

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

robertsLando
Copy link
Member

Fixes #3817

@coveralls
Copy link

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 12990086483

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 63 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 21.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/config/store.ts 0 1 0.0%
api/lib/ZwaveClient.ts 0 62 0.0%
Files with Coverage Reduction New Missed Lines %
api/lib/logger.ts 1 89.27%
Totals Coverage Status
Change from base Build 12866617879: -0.04%
Covered Lines: 3952
Relevant Lines: 20000

💛 - Coveralls

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this gracefully handle existing nodes.json? It's not entirely clear to me how much magic is behind the scenes.

I wouldn't want to delete all names and locations for users who have them set.

@robertsLando robertsLando changed the title fix: store nodes.json using homeHex fix: store nodes preferences in nodes.json using homeHex Jan 27, 2025
@AlCalzone
Copy link
Member

Ok, let me do a quick test

@AlCalzone
Copy link
Member

We should probably also clean up these entries when migrating:
grafik

@robertsLando
Copy link
Member Author

@AlCalzone done

@AlCalzone
Copy link
Member

Also, should we delete entries when hard-resetting the controller? Afterwards the current home ID is "lost", unless someone restores an NVM backup. Not entirely sure.

@robertsLando robertsLando merged commit e913f10 into master Jan 27, 2025
9 of 10 checks passed
@robertsLando robertsLando deleted the nodes-store-update branch January 27, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After switching controllers, the node names and locations are attributed to the wrong devices
3 participants