-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: store nodes preferences in nodes.json
using homeHex
#4104
Conversation
Pull Request Test Coverage Report for Build 12990086483Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this gracefully handle existing nodes.json
? It's not entirely clear to me how much magic is behind the scenes.
I wouldn't want to delete all names and locations for users who have them set.
nodes.json
using homeHex
Ok, let me do a quick test |
@AlCalzone done |
Also, should we delete entries when hard-resetting the controller? Afterwards the current home ID is "lost", unless someone restores an NVM backup. Not entirely sure. |
Fixes #3817