Added forward/backward derivatives for divergence on Cartesian grid #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VascoSch92
reviewed
May 13, 2024
|
|
||
| Returns: | ||
| A function that can be applied to an array of values | ||
| """ | ||
| if method not in {"central", "forward", "backward"}: |
There was a problem hiding this comment.
If you are using Literal, you don't need this check :-)
There was a problem hiding this comment.
I don't think I agree. Typing is optional in python, so a user could easily pass different values (for instance by mis-typing!) and those would not be caught at runtime. The check basically ensures that the right values were given at runtime, whereas the type hint helps developers with proper IDEs and type checking.
There was a problem hiding this comment.
are you sure? Can you give an example?
If you look into the docs of Literal you can see that it is not optional, but you have to give a specified value.
But better double checking than not checking at all ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.