-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multigraph rules fixes: bialgebra #248
Multigraph rules fixes: bialgebra #248
Conversation
merge master to multigraph-rules-fixes
…ersion with multigraph support
…s.py as it increases the number of vertices
I have covered the three implementations of bialgebra in rules.py, basicrules.py and editor_actions.py. Let me know if that looks alright to you. |
I don't claim to fully understand what is going on here, but if you say that this indeed correctly implements the bialgebra rule and deals with all the weird edge cases you can have when you work with a multi-graph, then I'm happy to merge it. |
I have tested with the weird cases and I believe it is correct. I can't guarantee that I haven't missed anything but previously the bialgebra rule was completely broken so this is at least an improvement. Few comments:
|
No description provided.