Add background option for disabling theme background colours
#3530
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to configure whether the theme's background color is displayed
OpenSauce04
force-pushed
the
background-option
branch
from
c6e888a to
7e339d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new option which allows the user to configure whether the background colour of the theme is used.
This is useful for allowing users to have a transparent background with a simple configuration option, rather than manually editing any theme they use, which is currently the only alternative and is very unfriendly to the user.
I am unfamiliar with both Go and this codebase, so if I have made any mistakes in this pull request such as not following best practice or impropper code placement, please correct me.
Please also let me know if this is the correct way of addressing this issue or if you would rather a different approach is taken.