status.lua: Display commit and branch of repository where file is located
#3673
Conversation
Return current commit hash and branch of repository where file in buffer is located instead of current directory. Update version to 1.1.0.
| @@ -32,30 +35,23 @@ function size(b) | |||
| return humanize.Bytes(b:Size()) | |||
| end | |||
|
|
|||
| function branch(b) | |||
| local function parseRevision(b, opt) | |||
| if b.Type.Kind ~= buffer.BTInfo then | |||
There was a problem hiding this comment.
One Addition:
In case we now compare against buffer.BTInfo shouldn't we use b.Type instead of b.Type.Kind?
Because the b.Type.Kind holds the int, but the b.Type the BufType.
There was a problem hiding this comment.
BufType.Kind is exposed to plugins with the same name as BufType constants, so b.Type.Kind has to be compared:
Lines 129 to 134 in 272a308
I do not know if the exposed values could somehow be changed without breaking API. Other exposed constant types are int but I was confused when I tried to compare with b.Type a year ago. Thinking about it now, I think a note could be added in documentation.
There was a problem hiding this comment.
Ah, I see. Thank you for this hint. 👍
Not really intuitive, but yes...right now fix in this API.
| VERSION = "1.0.0" | ||
| VERSION = "1.1.0" |
There was a problem hiding this comment.
The version of builtin plugins does not seem to be updated and there is only a fix done in this pull request, so I don't know if this would be fine. I'll revert this sometime around this week.
There was a problem hiding this comment.
This version as such doesn't make a lot of sense for builtin plugins (they are not released separately from micro, not downloaded or installed separately from micro). So yes, I think it's better to keep this 1.0.0, just for consistency.
There was a problem hiding this comment.
What about VERSION = "builtin", which results in this particular case in status (0.0.0-builtin)?
There was a problem hiding this comment.
It's probably better to leave it as-is unless it is causing problems. It is sort of user-facing so changes could potentially break something (https://xkcd.com/1172/).
There was a problem hiding this comment.
By taking https://xkcd.com/1172/ serious we would end up in no change at all. 😉
The user is still able to override builtin plugins with local ones. Don't you think it would be nice to identify this use case?
There was a problem hiding this comment.
The user is still able to override builtin plugins with local ones. Don't you think it would be nice to identify this use case?
I'm not sure how the version number is related, surely you can do that regardless of the version number? 🤔 Or do you just mean that the text "builtin" would then not be visible in the output of micro -plugin list (assuming the user remembered to change the version number in their override)? I don't really think that matters much.
The repository where the file is located could be different with the current directory, so the functions in the
statusplugin are changed to run commands in the directory of the file.