Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First wave of changes #22

Merged
merged 43 commits into from
Feb 1, 2025
Merged

First wave of changes #22

merged 43 commits into from
Feb 1, 2025

Conversation

bratpeki
Copy link
Contributor

This first set of changes aims to finish all the "TODO" statements made in the manual, as well as make minor adjustments along the way. Once all the changes have been made, this PR is to be squashed and merged accordingly.

I ask the maintainers to not merge this until ready.


[glossary]
Key:: A possible input to Zyn-Fusion, with a specific notation (eg. A4, G#2, etc). Practically, it's the same thing as a note.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not proposing a change, but for elsewhere in the docs be aware that this is an overloaded term and may be used to talk about a whole scale in the microtonal sections of the app.

Timbre:: The percieved quality of a sound. Different oscillators produce different timbres.
VU meter:: A meter that displays the average level of an audio signal.
Voice:: A single instance of sound a synth can produce. If you are limited to three voices, you can only play three notes at one time and expect to hear them in the final sound.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the primary usage, but same as the last comment be aware that this gets overloaded to include a smaller contributing element within the add synth engine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on this? What changes would you propose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For definitions that have multiple usages I'd mention the options in the definition. e.g. voice in most synths is typically an instance of something producing a sound, but in zyn it also refers to a piece of add synth where each voice in an add synth instance features one oscillator and one modulating oscillator.

Manual.adoc Outdated
=== Synthesizer Modules
include::SynthesizerModules.adoc[]
// === Synthesizer Modules
// include::SynthesizerModules.adoc[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that commenting these out is part of the WIP nature of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as I finish each part up, I uncomment the next one. Makes the PDF and TOC more managable, since the WIP content is always at the bottom and not somewhere in the middle of the doc.

When you run Zyn-Fusion you'll be presented with this window:

// TODO: Color the elements here and use the colors as help.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one of the plans with the automated screen capture wasn't recoloring, but making it semi-easy to draw bounding boxes around areas you wanted to highlight to users. I do not recall the status of that functionality however.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable, thank you for letting me know! I won't force such a functionality, then.

Master VU meter::
This meter will display the current audio output levels. It can be useful for a few things:
* It'll let you decide on choosing an optimal sound level for your patch.
* It might be helpful to find out which instance of Zyn-Fusion is currently making sounds, if you're working with a few of them at once.
* It'll help you make sure your MIDI keyboard is connected properly.

VOLUME slider::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although the UI does use shoutcase (mostly for typographic reasons), I'm not 100% sure if it's the best for the manual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll switch it back!

Learn indicator::
This indicator shows when automation learning is in progress.

// TODO: More info about this in the manual?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this is something that should be discussed in another tutorial

This indicator shows when MIDI contoller learning is in progress.

// TODO: More info here
Learn indicator::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually am a bit worried about this documentation style. It's something that I've done in the past and sort of burnt out of documentation work. Enumerating everything in front of the user tends to make hard to read documentation and with something at the scale of zynaddsubfx it makes it an impossible task for you as the documentor. I'd drop some of these elements if you don't have something to tell the user about in a narrative sense.

@bratpeki
Copy link
Contributor Author

bratpeki commented Aug 15, 2024

Thank you, I'll wait for your response on the question I've left, and then I'll correct everything!

@bratpeki
Copy link
Contributor Author

There is a commented-out segment in the effects relating to the effect routing dropdown menu, this should be checked at some point.

@bratpeki
Copy link
Contributor Author

Major changes to the file and TOC structure OTW.

@bratpeki
Copy link
Contributor Author

Slowly starting work on this again, it's gonna move at a snail's pace until my Linux machine is up and running, but I'll try to lay the foundation for speedy work in the future!

@fundamental fundamental merged commit a52d568 into zynaddsubfx:master Feb 1, 2025
@fundamental
Copy link
Member

Merged 👍

@bratpeki
Copy link
Contributor Author

bratpeki commented Feb 1, 2025

TY! Please also merge mruby-zest/mruby-zest-build#119 when possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants