Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Age of Apocalypse campaign box #457

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Conversation

jordanweiler
Copy link
Contributor

@jordanweiler jordanweiler commented Dec 16, 2023

This adds the Age of Apocalypse campaign expansion box that is scheduled to be released 2024-03-29.

I was able to import this locally and create new decks for Bishop and Magik without issue.

Notes:

  • Apocalypse I, II, and III in the En Sabah Nur set have duplicate numbers (179, 180, 181) with other cards. I decided to move these to the end of the cards to keep them unique but their new numbers (184, 185, 186) doesn't exactly match the cards. I'm not sure of another way to do this since it seems like a misprint.
  • One of the main scheme cards has X as the threat value so I had to allow -1 in the card schema.
  • A few cards haven't been released yet so I'll need to come back later and update them. They are only in the encounter sets so I figure it wasn't a big deal. The cards are 45181a and 45183a.

pack/aoa.json Outdated
"resource_physical": 1,
"set_code": "bishop",
"set_position": 13,
"text": "<b>Response</b>: After Agent 13 enters play, remove 2 threat from a scheme.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed

@jordanweiler jordanweiler marked this pull request as ready for review March 27, 2024 04:48
@Kamalisk
Copy link
Collaborator

I dont know the details of the cards, but I would guess just adding letters to the duplicate numbers would suffice. If they are encounter cards though the codes dont matter too much.

@Kamalisk Kamalisk merged commit 90b5517 into zzorba:master Mar 30, 2024
1 check passed
@jordanweiler jordanweiler deleted the add-aoa branch March 30, 2024 03:07
@jordanweiler
Copy link
Contributor Author

I dont know the details of the cards, but I would guess just adding letters to the duplicate numbers would suffice. If they are encounter cards though the codes dont matter too much.

They are encounter cards so I didn't think it was a big deal but I wanted to document the choice on the PR. The Apocalypse cards (179-181) have A, B, and C sides and the Overseer/Prelate cards (179-181) also have A and B sides so it wasn't as simple as adding a letter for uniqueness. Also with the way the octgn_id is generated (using the pack position) keeping the position numbers duplicated across two separate cards would have generated the same octgn_id for two different cards and that seemed like a potential issue. I ended up shifting the 179-181 Apocalypse cards to positions 184-186 to avoid the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants