-
-
Notifications
You must be signed in to change notification settings - Fork 237
Fix ExpressionHelper.TryConvertTypes to generate correct Convert in case left or right is null #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ase left or right is null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves null handling in type conversion when comparing objects with non-object types in dynamic LINQ queries, particularly for JSON parsing scenarios. The changes ensure that null object values are properly converted to default values instead of causing runtime exceptions.
- Enhanced
TryConvertTypesto use conditional expressions that check for null before conversion - Updated
GenerateDefaultExpressionfor NET35 to properly handle value types and reference types - Refactored test variable names and data structures for improved clarity
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/System.Linq.Dynamic.Core/Parser/ExpressionHelper.cs | Added null-safe conversion logic with conditional expressions and improved NET35 default value generation |
| src/System.Linq.Dynamic.Core/Parser/IExpressionHelper.cs | Removed unnecessary public modifier from interface method |
| src/System.Linq.Dynamic.Core.NewtonsoftJson/NewtonsoftJsonExtensions.cs | Refactored to use collection expression and extracted func result to local variable |
| test/System.Linq.Dynamic.Core.Tests/DynamicClassTest.cs | Renamed test variables for clarity and changed List to array |
| test/System.Linq.Dynamic.Core.SystemTextJson.Tests/SystemTextJsonTests.cs | Added test for non-existing member comparisons with new imports |
| test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs | Added test for non-existing member comparisons and commented-out test for optional properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs
Outdated
Show resolved
Hide resolved
test/System.Linq.Dynamic.Core.SystemTextJson.Tests/SystemTextJsonTests.cs
Outdated
Show resolved
Hide resolved
test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs
Outdated
Show resolved
Hide resolved
…sonTests.cs Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…