Skip to content

Conversation

@StefH
Copy link
Collaborator

@StefH StefH commented Nov 2, 2025

@StefH StefH self-assigned this Nov 2, 2025
@StefH StefH added the bug label Nov 2, 2025
@StefH StefH requested a review from Copilot November 2, 2025 09:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves null handling in type conversion when comparing objects with non-object types in dynamic LINQ queries, particularly for JSON parsing scenarios. The changes ensure that null object values are properly converted to default values instead of causing runtime exceptions.

  • Enhanced TryConvertTypes to use conditional expressions that check for null before conversion
  • Updated GenerateDefaultExpression for NET35 to properly handle value types and reference types
  • Refactored test variable names and data structures for improved clarity

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/System.Linq.Dynamic.Core/Parser/ExpressionHelper.cs Added null-safe conversion logic with conditional expressions and improved NET35 default value generation
src/System.Linq.Dynamic.Core/Parser/IExpressionHelper.cs Removed unnecessary public modifier from interface method
src/System.Linq.Dynamic.Core.NewtonsoftJson/NewtonsoftJsonExtensions.cs Refactored to use collection expression and extracted func result to local variable
test/System.Linq.Dynamic.Core.Tests/DynamicClassTest.cs Renamed test variables for clarity and changed List to array
test/System.Linq.Dynamic.Core.SystemTextJson.Tests/SystemTextJsonTests.cs Added test for non-existing member comparisons with new imports
test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs Added test for non-existing member comparisons and commented-out test for optional properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StefH StefH requested a review from Copilot November 2, 2025 13:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StefH StefH merged commit 8874662 into master Nov 2, 2025
4 checks passed
@StefH StefH deleted the json-non-existing branch November 2, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants